Jan Kotas

Results 408 comments of Jan Kotas
trafficstars

> I think having a well defined bar for what constitutes a critical infrastructure issue Proposal: Issue that caused large number (>5%) of PRs to fail in last 48 hours,...

> If it's possible to quantify the impact of a problem, this would be a bar worth investigating. You do need to quantify the impact precisely. For example, it should...

> a consistent error message can be identified, that should be a regular Known Issue, so that it will be used for error matching on a PR Yes, that is...

One source of the confusion is that the label is called "Known Build Error", but we use it for both build errors and failing tests. Builds and tests are two...

This would help runtime if this information is collected on all machines where .NET runtime runs, including production machines. If you collect this information only in places where .NET SDK...

That constructor is very unsafe. We have moved all unsafe Span operations to MemoryMarshal. The public equivalent of this constructor is `MemoryMarshal.CreateSpan` API.

So you can write `get { return MemoryMarshal.CreateSpan(ref _cFileName[0], MAX_PATH); }` today.

There is also `MemoryMarshal.CreateReadOnlySpan`. It is better to use that (to avoid the extra cast for JIT to optimize out) if you want to create ReadOnlySpan.

> One way to do this would be to have the compiler always produce a warning when a compiler-generated defensive copy is generated for a struct type that has some...

You would switch to native profilers to profile unmanaged memory allocators.