Jan Kotas

Results 405 comments of Jan Kotas
trafficstars

https://github.com/dotnet/runtime/tree/main/docs/design/specs may be better location for this doc. It is not CoreCLR specific (botr is generally CoreCLR specific) and it augments ECMA spec (augments of ECMA spec live under docs/design/specs).

> @jkotas who would be the right person to review the ILCompiler and Crossgen2 changes? I can take a look or route as necessary once the feedback is addressed.

> GCSampledObjectAllocation > masks referencing allocation (COR_PRF_MONITOR_OBJECT_ALLOCATED, COR_PRF_ENABLE_OBJECT_ALLOCATED) should apply to all heaps. How is this expected to work for file-backed non-GC heap segments? I think it would be more...

I do not see any hits in last week, so there is a good chance that this is fixed.

Stack trace of the crash (the hangs seems to be caused by crash reporting taking too long, so same root cause): ``` ntdll!ZwWaitForMultipleObjects+0xa [d:\blue.obj.amd64fre\minkernel\ntdll\daytona\objfre\amd64\usrstubs.asm @ 894] ntdll!RtlReportExceptionEx+0x452 [d:\blue\minkernel\ntdll\wer.c @ 982]...

The place to ask about this is https://teams.microsoft.com/l/team/19%3aa88bb61ffc1a4392ad38ebbc526c86f8%40thread.skype/conversations?groupId=4d73664c-9f2f-450d-82a5-c2f02756606d&tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47 Teams Channel.

> Is relying on reflection to set an init property a good long-term decision? It defeats the point of the source generators. > Is the runtime guaranteed to allow reflection...

> Use array instead of List > Revert "Use array instead of List" Was there an actual problem or you did not like the result? (It looks better to me...

The Unix specific APIs for working with files are available in Mono.Posix library today: http://docs.go-mono.com/?link=T%3aMono.Posix.Stat%2f* Mono team has done the work to build .NET Core-compatible version of Mono.Posix (https://github.com/mono/mono/pull/4774). Is...

> Do the same for TypeDesc (diffs are pretty small from it though) I think it would be a good idea to address this as part of this PR. (I...