Eliza Weisman

Results 571 comments of Eliza Weisman

My guess is that the very large number of lost waker warnings is due to issue https://github.com/tokio-rs/console/issues/149 --- warning sometimes causes false positives, which we're working on fixing. Sorry about...

> I see this bug in the release build also. https://i.imgur.com/cC2BHAK.png Yes, the false positives for the lost waker warning is expected to occur in both debug and release builds....

I believe #238 fixes this issue. Are you able to try the latest git revision of `console-subscriber` (fdc77e28d45da73595320fab8ce56f982c562bb6) and confirm that this is the case? You'll also need to build...

I marked this as `E-hard` because a _complete, full-featured_ filtering implementation is going to be a big pile of work (see the "questions" section above). However, an initial MVP where...

> There's also other things we'd probably want to be able to "enter" dynamically, like rewinding to a certain spot, or changing a config value, etc. Yeah, it would make...

(@LucioFranco might have advice on this?)

Oh, okay, so it seems like the `tokio-console` crate (purely a client) should use the `channel` feature, rather than `transport`?

ahhh, good catch...that makes sense! hmm. this is a problem that's kind of endemic with the `#[tokio::main]` macro; I've also seen people confused when an `#[instrument]` attribute on `main` doesn't...

> Is there a workaround for that? Rather than using `#[tokio::main]`, use [Tokio's `Runtime::new()` API](https://docs.rs/tokio/latest/tokio/runtime/index.html#usage), and ensure that `console_subscriber::init()` is called _before_ creating the Tokio runtime. For example, if you...

A potential follow-up might also be to support configuration _values_ associated with warnings, such as the threshold percentage for the self-wake warning.