Eliza Weisman

Results 571 comments of Eliza Weisman

> For what it's worth: `Instant::as_u64` has been removed in a yet-to-be-released change as part of slimming down the public API prior to a 1.0 release. Users have used crossbeam's...

I guess `crossbeam_util` is _probably_ in enough people's dependency trees already that it's maybe okay to add the dependency...

Since using the console already requires enabling `tokio_unstable`, we can probably just use `task::Builder` to add a name, anywhere we spawn a task. In the future, it would be nice...

#117 added names to the console's `aggregate` and `serve` tasks. However, we can't easily name the per-connection tasks spawned by Tonic without switching to tonic's lower-level API and writing our...

@g2p it's definitely possible to use `dynamic_filter_fn` to filter out those spans at the subscriber-level, but I think the best long-term solution is to add filtering to the console UI:...

The console uses [`tonic`](https://crates.io/crates/tonic) as both the gRPC server (in the `console-subscriber` crate) and as the gRPC client (in the `tokio-console` command-line application). It looks like a PR to add...

Yes, once we merge #318, it should be pretty easy to add support for Unix sockets. I've been out of the office for the last four days, so I haven't...

I haven't had the time to work on this, but now that Tonic 0.7 is out, it should certainly be possible and (I imagine) fairly straightforward. I'd happily merge a...

We may want to consider a fully-featured system for displaying non-fatal console internal errors in the UI. Perhaps this could piggyback on the warnings system? It would be nice to...

I think we probably _do_ want one or two fractional digits, at least for larger units like seconds, but definitely not 4 like we have currently.