Eliza Weisman

Results 571 comments of Eliza Weisman

@inanna-malick hmm, in theory, that could work! Could be worth experimenting with.

It looks like CI is stuck on this PR --- not totally sure what's going on there.

Looks like that was my fault; I changed the CI configuration, and it should run correctly now.

oh, looks like miri doesn't play nice with thread-locals (unsurprising), which means that both loom _and_ the crate itself won't compile. that tracks. since miri doesn't support concurrency, though, running...

> In the `Slab`s case we need the type to be an `Option` in order to call `Option::take`. Since we're not actually _returning_ the `take`n item in this code path,...

@bIgBV Are you interested in working on this? I'd like this to be addressed before we publish a release with the object pool API. If you're busy, I'm happy to...

Okay, great. I think this is the last release blocker for the pool.

Looks like this _probably_ isn't going to be possible with the current state of things (see https://github.com/hawkw/sharded-slab/pull/33#issuecomment-607039927 and https://github.com/hawkw/sharded-slab/pull/33#issuecomment-607352267) so I'm not going to block the release on it.

> I'm guessing this is the cause of a panic at the following line: https://github.com/hawkw/sharded-slab/blob/81c1c3fa846c364d9fcd6a7dde7841a7ce80f14b/src/shard.rs#L297 ? > > > > If anything, replacing that `[idx]` with `.get(idx).expect("too many threads")` would...

Thanks for the report, we should definitely fix this. It may be necessary to special-case the slab being empty in the `Iterator` impl...