Eliza Weisman

Results 571 comments of Eliza Weisman

Related: https://github.com/tokio-rs/console/issues/148

Yeah, this is a great idea. It would be nice to have some fairly modular way of defining warnings, similar to clippy --- obviously the actual detection of warning conditions...

FWIW, I'm personally strongly in favor of doing this work in the UI application. Eventually, if we want to have multiple UIs, I expect we would factor out the core...

Initial framework for warnings added to the `console` crate in #113 and #123. Right now, we can associate warnings with tasks and display them! However, we only have a single...

Some additional things that would be nice to add: - some kind of short identifier for warnings (either a short string name like `"poll_time_percent"` and/or a number like `[W0001]`) -...

If we did this, we could consider also having the `create` API return the mutable guard rather than taking a closure. When the slot has been mutated, the guard can...

Off the top of my head, I think that it _should_ be possible to make the guard `Send`. I believe the `Shard` reference is what is currently making it not...

Hmm, interesting. The panic is occurring here: https://github.com/hawkw/sharded-slab/blob/cf2537f3a5bd6ea21e9e48ecc22f05522ca7821e/src/page/slot.rs#L718 where we are trying to decrement the number of outstanding references to a slot, but the number of references is zero. I...

> We create several pools without customising the config, so we will have multiple references to the config object; References to the config object shouldn't be an issue...this code runs...

We could do this — it might be useful for the `tracing-subscriber` use-case, as well, where we're currently adding 1 to all indices because 0 is reserved. However, 0 _is_...