Jonathan Hall

Results 172 comments of Jonathan Hall

CSS and HTML are the only initialisms I see now that are not already all-caps. We have several instances where these are already caps (`ParseHTML()`) and where other initialisims are...

@hectorj Did you find a solution that works for you? I'm needing something similar.

IMO, this could only be changed with an opt-in to the `json.Decoder` type, similar to the `DisallowUnknownFields()` option added in Go 1.10. Maybe it `EnforceStrictNull()`?

I've been thinking about this, and I'm not sure that adding an option to `json.Decoder` is actually the right approach. It may be better to do this in a struct...

A creative solution. It obviously only works for defined types (i.e. `map[string]interface{}` wouldn't work). Maybe that's okay? I'll continue to ponder.

I shuold ammend my suggestion to run all of the `_cluster_setup` step, not just create `_users`. Or is there a reason that this cannot be reasonably automated?

> have a look at https://helm.sh/docs/topics/charts_hooks/ for automation Are you saying a PR to do this would be welcome on this project? Or you prefer to keep this up to...

E2E tests do pass for me, once I apply this small patch. Should I add this to the PR? ```diff --- a/test/kind-config.yaml +++ b/test/kind-config.yaml @@ -1,5 +1,5 @@ kind: Cluster...

> * `adminPassword` might not match what's deployed. This is a hangover from allowing users to set the admin hash explicitly to ensure that all pods use an identical value,...

I seem to have spoken prematurely about the passage of E2E tests. I see now there is an error. I get the same error when running the tests against `master`...