Jonathan Hall

Results 172 comments of Jonathan Hall

should be fixed by #59

I think I'm in favor of option #C. Using `err.Error()` has made our logs much harder for us mere humans to read quickly.

In the end, though, I think this is a bug/misfeature in Sentry, not in this library.

Upon further reading, it does seem that logrus_sentry is improperly assigning culprit. It's intended to be a function name, not human readable text. See [here](https://docs.sentry.io/clientdev/attributes/). Even so, that doesn't address...

Indeed, any change to this functionality will likely break someone. I propose that any change is done as an option, with the existing ("broken") behavior as the default.

Closing this unless/until we get another report with a reproduction case.

@l3pp4rd Any objection to me updating this PR to get it merged?

@lopezator This project has seemingly gone without a lot of attention for quite a while. I'm sure this PR just got lost when attention was focused on other tasks at...

@Yiling-J Good suggestion. I've added a very simple test to exercise just the new code. WDYT?