Jonathan Hall

Results 172 comments of Jonathan Hall

I've added an example. Feedback welcome. It's hard to know how detailed to be in an example.

Re: `logrusentry` vs `logrussentry`, it was an intentional wordplay, but perhaps that violates the principle of least surprise? I can go either way ;) I guess it probably matters very...

> if there are no references to any exported names of this package, then there is no need to run any initializers? Doesn't this description omit the (common?) pattern of,...

Thanks @mvdan. I appreciate your arguments against including this in this tool. They're in line with some of my skepticism about including it here as well. Let me offer a...

`golangci-lint` also uses the analyzer interface, so creating a linter for that project would kill that second bird with the same stone.

Here are some very high-level, preliminary results from my investigation. I've counted total number of clothed and naked returns, as well as the number of functions that mix naked and...

> Did you mean to make that open source, or is the link perhaps incorrect? I did. It's public now. > here's a rather simple ranking based on stars and...

Took me a while to get back to this, but I've now run the naked return analysis on the collection of repos at https://github.com/mvdan/corpus/blob/master/top-100.tsv: Corpus | Total returns | Clothed...

Similar panic in the stdlib on [this file](https://github.com/golang/go/blob/c19c4c566c63818dfd059b352e52c4710eecf14d/test/dwarf/linedirectives.go), although this one appears to be intentionally "broken" (not sure if that means gofumpt should actually panic, though): ``` $ gofumpt -w...

This is failing to properly adjust the location of comments after inserting the return values. I'll continue working on that.