Edouard Choinière

Results 497 comments of Edouard Choinière

I saw that the new tests pass now! You are getting close!

Also, do you have experience with https://docs.renovatebot.com/modules/manager/nix/? We enabled precommit, that is also opt-in.

So you want to change this PR or have a new one for it?

Looks great to me! What will be the steps needed in regards to grass-addons after that change? Will they work out of the box?

I was about to approve, but did a quick other check. There's two things that stood out.

@wenzeslaus I manually resolved the conflicts

Before having the code removed, I consider it a good idea to fix this missing space, so it is at least that less of a bug when someone wants to...

> @wenzeslaus Can you please point me to the db.univar module, I am unable to find it. https://github.com/OSGeo/grass/tree/f13b37931af919be04fa14f392a1f9ea9aa183fd/scripts/db.univar

Not quite ready to merge, need to investigate more on the failure

During the community meeting, I tried to make it pass. The old version of Pylint we used didn't support later Python versions, like Python 3.12, since some parts were removed....