Edouard Choinière

Results 497 comments of Edouard Choinière

There is also a significant number of mutable values used as a default argument. That is quite dangerous, and it was dangerous in the Python 2 time also. For example,...

Also note that the "coverage" change that you might see is still flawed, as this PR will add new files "seen" by the coverage tool. It doesn't know about all...

> > The test fixture `space_time_raster_dataset` used in some pytest tests, including in some of the Jupyter tests, is unexpectedly slow at the setup stage when running in pytest with...

I have other changes queued to these files (dating from the last day of the sprint), so I'm waiting for this to be merged first.

I had to rerun about 4-5 pytest failures on main that worked on a second try. I would've hoped that this would have fixed it

Now I'm trying to push for this PR to be merged, as we still have some pytest flaky timeouts that I'm convinced this will help a bit. And also was...

In curious to see if the dbif.close() changes from https://github.com/OSGeo/grass/pull/3996/files#diff-30a61f23aa90129beedbff09dd723876e2a54703c7355eaef4e45a8827eaecda would change something… It hasn’t been there enough for it, and for the CI on my side on my PR...

I know that there are some changes in ctypesgen, but I also upstreamed them in https://github.com/ctypesgen/ctypesgen/pull/217. We are also due to sync up with upstream ctypesgen soon.

There are 11 other non-automatic fixes to apply in another PR

@cwhite911 the PR will automatically merge once all conditions are met, that means that there's only open conversations remaining