Edouard Choinière

Results 497 comments of Edouard Choinière

Oh, maybe you don't even have triage access for the grass repo but maybe others? It's surprising.. Comment like done on them, to make sure we don't forget some, and...

The action in the CI doesn't support clang-format 18 yet. So we need to wait before updating the pre-commit side. See https://github.com/DoozyX/clang-format-lint-action/issues/68, blocked by https://github.com/muttleyxd/clang-tools-static-binaries/issues/39, which is already solved and...

See https://github.com/OSGeo/grass/issues/3921 on what is needed before being able to change to versions higher that the one we use.

I've finally managed to get something, a great start. There's more rules checked, but for now, to allow just running, some rules that were always checked might be disabled for...

The codecov shouldn't be sending comments, it was explicitly disabled in config. Is it because the branch doesn't include the config file (not enough updated from main)?

Seems like it was the case..

Before merging, can you make sure that your PRs are either formatted according to clang format 18 (changed 2 days ago), or merged from main?

Solved conflicts. Also renamed the test folder so it can be collected by gunittest

Pylint config should be recreated from scratch using the new defaults. Ideally inside pyproject.tonl too.