Daniel Weck

Thorium, just like other apps built with Electron, doesn't control at a low-level how file associations are created. I guess Electron Builder broke some Windows 10 backward compatibility ... or...

PS: also notice the low-constrast modal perimeter (important todo, IMO), and the style of the keyboard-focused delete button / menu item (nit-pick)

if we're not going to make tags names editable, then let's replace the edit (pen) icon with the correct affordance signal: a delete icon (rubbish bin, like in the popup...

I'm used to it now, but at first I immediately found this icon confusing, I had not come across this design choice before (websites or apps). Would it be possible...

PS: also note the low-contrast popup modal dialog perimeter, as mentioned in other issues in this tracker. Needs harmonization / consistency across library and reader windows.

light mode screenshots (thank you Mylene ;)  

The "lock" / "keyhole" icon looks fine, but the right hand side alignment is inconsistent with other Thorium text input fields, and usually reserved for the "reset" / "clear" cross...

A good test for large sections of text (which would normally result in far-too-long speech utterances, and therefore benefit from sentence detection) is Georgia: https://idpf.github.io/epub3-samples/30/samples.html#georgia

Navigator code reference: https://github.com/readium/r2-navigator-js/blob/91482324fa2313c4536c48693eb091464a483071/src/electron/renderer/common/dom-text-utils.ts#L8 https://github.com/readium/r2-navigator-js/blob/91482324fa2313c4536c48693eb091464a483071/src/electron/renderer/common/dom-text-utils.ts#L935-L978

I'd like to resolve this. must verify that the sentence breaking algorithm still works with Japanese (Thorium's current third party lib works with a broader set of locales but is...