Daniel Weck comments

Results 1516 comments of


                                            Daniel Weck

progression bar popout / callout shows correct spine item in reading order, but shows percentage of currently rendered document (confusing)

Also incorrect callout arrow position, I am guessing because of horizontal shift to fit popout into view (offset to the left)

progression bar popout / callout shows correct spine item in reading order, but shows percentage of currently rendered document (confusing)

the current progression bar navigation has a few outright bugs (with PDF notably) but also the callout is confusing since it expresses the actual progress when displayed for the current...

There is a problem with the "TTS voice" option menu of thorium-reader alpha3.0 version.

duplicate: https://github.com/edrlab/thorium-reader/issues/2128

like keyboard shortcut editor, annotation editor should tab-cycle and lock keyboard, otherwise confusing screen reader experience

there's very little UX benefit in allowing concurrent annotation edit, in fact I can only see negatives :)

like keyboard shortcut editor, annotation editor should tab-cycle and lock keyboard, otherwise confusing screen reader experience

compare with keyboard shortcuts editor exclusive mode:

[PARKED] waiting on ReadiumCSS ... Japanese settings in src/utils/fontList.ts

Great expert feedback, thank you very much :) @JayPanoz I borrowed the original font face recommendations from ReadiumCSS, let's see how to backport the proposal here into RCSS

[PARKED] waiting on ReadiumCSS ... Japanese settings in src/utils/fontList.ts

https://github.com/readium/readium-css/blob/master/css/dist/ReadiumCSS-ebpaj_fonts_patch.css

[PARKED] waiting on ReadiumCSS ... Japanese settings in src/utils/fontList.ts

Thank you once again for looking into this. The navigator changes are actually directly related to the upstream ReadiumCSS project. @JayPanoz could you please take a look? Adding the recommended...

[PARKED] waiting on ReadiumCSS ... Japanese settings in src/utils/fontList.ts

Related: https://github.com/readium/r2-navigator-js/pull/79

[PARKED] waiting on ReadiumCSS ... Japanese settings in src/utils/fontList.ts

Resolution: https://github.com/readium/readium-css/pull/146