Daniel Weck

Hello @panaC I experience results pagination bugs with annotations, even after fixing the hard-coded max limit (I discovered this bug by switching from 10 to 3, to test whole/partial pages...

I am merging this PR as it fixes multiple issues. I will file a separate issue for the pagination / state inconsistencies

new issue https://github.com/edrlab/thorium-reader/issues/2344

Please make sure to only make changes to en.json via GitHub, all other locales should be modified via GitLocalize for now (until we fully understand the merge conflict risks) https://github.com/edrlab/thorium-reader/issues/2219

I agree (personal preference) about making this global state instead of publication-specific.

Hi Arthur, I am taking over this PR as the test matrix is quite extensive and we know from experience that the zero-based versus one-based indexing is tricky (I spotted...

To reproduce, make sure there is only a single bookmark in the list. No need to enter edit mode (actually), simply press the delete icon

`if (!r2Publication || !annotationsQueue)` ...this should be `if (!r2Publication || !annotationsQueue?.length)`

just need to hoist conditional early render() exit AFTER all hooks called?

https://legacy.reactjs.org/docs/hooks-rules.html#only-call-hooks-at-the-top-level