Daniel Weck comments

Results 1516 comments of


                                            Daniel Weck

[PARKED] waiting on ReadiumCSS ... Japanese settings in src/utils/fontList.ts

ReadiumCSS backport into navigator: https://github.com/readium/r2-navigator-js/commit/17b86f29487ff90f73ae8e754287ee91dc1c222e

[PARKED] waiting on ReadiumCSS ... Japanese settings in src/utils/fontList.ts

Fixed via https://github.com/edrlab/thorium-reader/commit/3a79251e804c0b41af0039e5fee40e01eecf7cbe Thank you @peaceroad

pagination selector is editable (arbitrary text can be entered)

Fixed by replacing with native selectoption control: https://github.com/edrlab/thorium-reader/pull/2332#issuecomment-2127722233

some OPDS "buttons" / GUI controls only activate with enter key, not space bar (are they "a" instead of "button" tags?)

"a" for external hyperlinks (like the LCP hint URL, the "what is OPDS" link etc.) obviously make sense. But note that we have to be very careful with links: https://github.com/edrlab/thorium-reader/issues/2233...

some OPDS "buttons" / GUI controls only activate with enter key, not space bar (are they "a" instead of "button" tags?)

Perfect example here of link vs. button: https://github.com/edrlab/thorium-reader/pull/2286/files#diff-a7df694e28b199bdb42f482b27cc21e905201b5c6a035233f082002685a8f2aa ( I will add more code comments to highlight potential places to harmonise )

some OPDS "buttons" / GUI controls only activate with enter key, not space bar (are they "a" instead of "button" tags?)

yes, router Links usually make sense as 'a' HTML hyperlinks for navigation interactions, in which case space-bar keystrokes trigger scrolling (if the viewport is scrollable), and the enter key is...

adapt nb of breacrumbs items to screen width

Maybe one possible solution is to mimic https://github.com/edrlab/thorium-reader/pull/2358 ?

adapt nb of breacrumbs items to screen width

Superseded by https://github.com/edrlab/thorium-reader/pull/2445

Publication metadata link can be mouse clicked but not ENTER key triggered (not keyboard accessible, though screen readers can emulate the click event)

Reminder: VoiceOver users - for example - can activate the hyperlink with CTRL+OPT+SPACE but ENTER on its own doesn't work, just as it fails for keyboard users who do not...