Sven Strickroth

Results 116 comments of Sven Strickroth

cf. https://github.com/gitster/git/blob/efe3874640e2e58209ddbb3b072f48f6b7094f34/refs.c#L721 and https://github.com/gitster/git/blob/efe3874640e2e58209ddbb3b072f48f6b7094f34/refs/files-backend.c#L218

@pks-t @ethomson Could you please have a look at this?

Have you considered to report some of the changes upstream to Scintilla?

If the algorithm in `StrToBase64.h/cpp` is directly based/copied from `base64.c/h`, then this file needs the header.

You could also use ATL for base64 to get rid of any dependency (https://msdn.microsoft.com/vstudio/ezec6x4e(v=vs.100)).

What do you mean with "core idea"? Base64 is standardized.

Scintilla_ChangeLog is not complete (e.g., 9f072017fed556c433741616fa05dc603065ce34 is missing). Optimally use some better approach such as special commits only affecting files in the scintilla-folder which can be cherry-picked or maintaining a...

Yesterday I build the vanilla Notepad2 sources (with VS2017) and got a binary of ~800kib, building bf22e43296723fae63e6651508800cb81b676abc alrteady resulted in ~1,2mib (x86).