Mojtaba Samimi

+1

@alexcjohnson could it be related to data revision somehow?

> @archmoj, I have a question regarding testing. I have looked through the code and did not find how you are testing the different clickmode flags under test\jasmine\tests\click_test.js. Could you...

> Hey @archmoj, I have added a couple of test but I would like to debug them to make sure I didn't forget anything and that the expected values are...

> Do I have to push the `dist/` and `build/` directories as well? They are not ignored. No. You should not commit them.

> Tests don't seem to fail due to my changes, right? We experienced failures on the CircleCI in the last week. Could you please fetch upstream/master and merge it into...

> Failing tests seem unrelated to my additions. From my side this feature is ready to be merged @archmoj They all passed now.

Thanks very much for the PR and the follow up. All looking good to me. Passing over to @nicolaskruchten and @alexcjohnson.

@vovavili could you please fetch upstream/master and merge it into this branch?

You need to set `shape.editable: false`. Also please note that `plotly-latest` does not load the latest v2. Here is the [working codepen](https://codepen.io/MojtabaSamimi/pen/YzazGaQ?editors=0010).