Mojtaba Samimi

Results 242 comments of Mojtaba Samimi
trafficstars

Thanks for the PR @nickmelnikov82 :medal_military: :dancer: Merging to master... I'll open a PR shortly after to address few remaining items.

I could imagine 2 different APIs for this. 1. To add `sizex` and `sizey` to `marker`. In this case the a circle marker become an `ellipse` when scaled in on...

What happens if you convert the dates to UNIX timestamps?

I tried your example in this [codepen](https://codepen.io/MojtabaSamimi/pen/wvxRqqV?editors=0010). Could you please explain the issue and possibly make the codepen the minimal case?

This would be resolved by #6947.

Please refer to the test file for the examples.

The `b64` image test is added by https://github.com/plotly/plotly.js/pull/5230/commits/2df73c437b9bc47155d913b09fb81a08837fbd2e and after handling typed arrays in various places, now succeeds to illustrate diffs in a number of remaining mocks. I'll continue fixing...

Now the (: only :) remaining mocks not matching baselines when converted to `b64` are: ``` "axes_category_categoryarray", "gl2d_point-selection", "gl3d_scatter3d-blank-text", "point-selection", "polar_bar-width-base-offset" ``` Investigating...

Thanks very much for the PR. This looks good. Please add a test in `packages/python/plotly/plotly/tests/test_optional/test_figure_factory/test_figure_factory.py` to lock this bug.

Have you specified both `width` and `height` in the layout? If no please check the result with those being specified. Thank you!