Mojtaba Samimi

Results 319 comments of Mojtaba Samimi
trafficstars

> Did anything actually change in the images you regenerated? They look identical to me. Please see the diffs below: ![diff-pattern_bars](https://user-images.githubusercontent.com/33888540/191102713-07626fc1-abd5-4194-8aa7-f2626ccab1ce.png) ![diff-scatter_fill_pattern](https://user-images.githubusercontent.com/33888540/191102745-81e46b94-910b-42a5-9380-f57744b9a5f1.png) BTW, they look identical to my eyes too.

> > Browser compatibility of [stroke-opacity](https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/stroke-opacity) and [fill-opacity](https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/fill-opacity) is unknown. > > We've been using those attributes all over the place for years, I think we can conclude they're safe...

> We still want to separate out [`bgcolor`](https://github.com/plotly/plotly.js/blob/adcb081a09fec15e7af2d70210e01a525b83cacd/src/components/drawing/index.js#L571) per the last part of my comment [#6318 (comment)](https://github.com/plotly/plotly.js/pull/6318#issuecomment-1251242102) Good call. Addressed in [4cd8011](https://github.com/plotly/plotly.js/pull/6318/commits/4cd801148adb4e3c8541941db9c6044cc669f742).

@alexcjohnson Let's merge this PR so I possibly open another one for few other components & traces. Thanks!

Please note that the default `hovermode` in v1 is `x` and in v2 is `closest`. So with v2 you could simply set `layout.hovermode` to 'x' for this graph.

I noticed the problem even on initial camera position.

This is happening because `ax._length`, `ax._offset` and `ax._mainLinePosition` for some axes are `undefined` or `NaN`. I labeled it as a bug.

Thanks @wilhelmhb for the great PR. My apologies for the late review. Kindly find my comments regarding the new attributes. Before adding new tests, I also suggest that you possibly...