Mojtaba Samimi

Results 242 comments of Mojtaba Samimi
trafficstars

@Atrema6 I was not able to replicate the problem. Please provide an animated gif or video file. Thank you!

> I'm not sure why the [webgl-jasmine](https://circleci.com/gh/plotly/plotly.js/203328?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-checks-link&utm_content=summary) tests are failing, it seems unrelated to this PR. Yes it is unrelated to this PR and it would be fixed on master...

Thanks for the PR. Please see my comment [here](https://github.com/plotly/plotly.js/issues/6768#issuecomment-1791124727) on how to add and handle an `arrayOk` attribute.

> I'm not sure why the [webgl-jasmine](https://circleci.com/gh/plotly/plotly.js/203328?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-checks-link&utm_content=summary) tests are failing, it seems unrelated to this PR. Please fetch `upstream/master` and merge it to this branch which would fix the `webgl-jasmine`...

> I think I might need some help with this. After running `npm start`, if you run `npm run schema` it would update `test/plot-schema.json` file. Then you can commit it....

Looking good to me. Could you please add a mock named `zz-pie-hole-array.json` at `test/image/mocks/` with some pies to test this feature? Thank you!

We are in the process of releasing a minor version soon. I'd like to include this feature but the test is still missing.

> I'm sorry I've been so inactive on wrapping up this issue. I've been taking a break. I'll be back next week to tackle this. I understand if the next...

Thanks for the PR. Looks good to me. Over to @alexcjohnson

> (oops part of the `upperfence` description still talks about the lower fence, cc @archmoj) > Now fixed by #6834.