Neil Girdhar

Results 329 comments of Neil Girdhar

This would be a fantastic change. I need to keep vim running just for dir-diff. (I can't use dir-diff with Neovim because it is confused by the folding https://github.com/will133/vim-dirdiff/issues/39.) That...

If we're re-engineering this, a compact grid mode would be really nice. That is, try: - putting everything on one line, - grid, and - hanging grid. Choose the one...

Thinking about this more, I would like to see the options in Ruff be something like: ```toml imports_allow_grid = true imports_allow_vertical = true imports_parenthesis_on_newline = false ``` Then the most...

@ThiefMaster That's the one I'm waiting for too. But really, what we need is for Ruff to support [both _vertical_ and _grid_ formatting](https://github.com/astral-sh/ruff/issues/8197). If we had that, we would have...

> nd we're considering making `isort` its own tool or integrating it into the formatter. I think integrating it into the formatter makes perfect sense. After all, all of these...

> there are entirely valid uses for checking if something is `True` or `False` without having a `__bool__` cast occur Of course this is a matter of opinion, but if...

Now that Ruff is moving towards having type information, this issue may eventually warrant some refinement? If `x` has Boolean type, then `if x` is appropriate and `if x is...

> I would argue that if x is not Boolean type, "is True" is always wrong - for example if x is numpy.bool_, comparing it with is will be wrong....

Edit: my mistake, I didn't reread the issue since I started following it years ago! ---- @markedwards Default values were recently drafted in [PEP 696](https://peps.python.org/pep-0696/) slated for Python 3.12, and...

@markedwards Looks fine to me (although this is a pointless use of defaults). Yes, as far as I know, no one implements PEP 696 yet.