Neil Girdhar

Results 329 comments of Neil Girdhar

Thanks for the quick merge. If anyone has time, it may be worth mentioning that most of the other uses of `TypeGuard` should actually be changed to `TypeIs`.

@albertvillanova Any chance we could get this in before the next release? Everything depending on HuggingFace has their NumPy upgrade blocked.

Why is it installing numpy 2 if the dependencies don't support it?

For me, I'm getting: ``` ❯ uv pip install --system "datasets[tests] @ ." Found existing alias for "uv pip install". You should use: "pipi" Resolved 119 packages in 934ms Built...

3.12.4 I'll try on 3.10 now.

> Alternatively, we should ignore/select tests depending on the installed versions. That works. Alternatively, you could depend on tensorflow >= 2.16.2 (etc.) for the tests?

> The issue I see is that our CI will not test numpy 2.0 indeed. Right, that's the advantage of the test skipping you wanted, I see your point. Thing...

> Without testing Numpy 2.0, we do not know if there are some other parts in the code broken. Yes, you're right. I understand you're point, but you could say...

Awesome, thank you! Please let me know if I need to do anything.