Neil Girdhar
Neil Girdhar
How is the linked function related? It doesn't deal with aggregate structures, which is the motivation for this proposal.
> I'm a little confused how your proposal would work. If a function takes a Distribution object, then that function already needs to know how to extract the relevant arrays...
> The reason I linked to the custom `get_namespace` in scikit-learn is that it is an example of an array consuming library having a custom version of `get_namespace` that implements...
@erictraut Is this a problem with Pyright?
So, I removed one of the overloads, but from my testing it didn't seem necessary anymore. I'll quickly try replacing it to see if it makes a difference. (Edit: still...
@erictraut Sorry, but I don't understand how these two functions are supposed to be the same. In the first function, you are checking against `DataclassInstance` whereas in the second you...
@JelleZijlstra There appear to be some errors with updating PyRight. Would you mind updating PyRight when you have a chance?
Updated. Ready for pull.
> (Weird design choice to have one function to check for both types and instances ...) Definitely a weird choice. So, can the PR be pulled, or should we wait...
Sounds good :smile: !