Neil Girdhar

Results 329 comments of Neil Girdhar

@emmanuelle Thanks for looking over this PR! The more eyes, the better. What do I need to do to add a "mypy check"? (Also good luck with the scikit annotations....

@jarrodmillman That project is just auto-generated stubs. Those auto-generated stubs have essentially no useful type annotations: nearly all of the type annotations are `Any`, which is tantamount to having no...

@fmagin I think the stubs package you wrote was a great first step, and made a lot of sense back years ago when you wrote it! Today, we need to...

@stefanv I think the stubs approach is going to prove more of a hassle than an advantage since it means a lot more work when making any change: More lines...

> `1 == True` returns True but `1 is True` returns False. That's why it will lead to confusing results when people pass in `1`. > This is useful when...

What do you expect this to do? ```python d = DiGraph() d.to_undirected(as_view=1) ``` or this? ```python d.to_undirected(reciprocal=1) ``` You don't think it's confusing that passing in `1` is a synonym...

Yes, I realize it's rare. No one's going to report it when they can work around it after debugging. As for when it can come up, someone might produce an...

Thank you very much @dschult! I guess I should explain my motivation for this issue. I figured that even if you decided to postpone adding type annotations, eventually all Python...

You're right. Mypy knows that it can be either. What it doesn't understand is that your try/except pattern regarding types. I guess it could theoretically be made to work as...