Neil Girdhar

Results 329 comments of Neil Girdhar

> I agree that having XLA does the fusion for you would be great. But this isn't a trivial fusion to add. First, XLA would need to learn how to...

> This seems more complex than it first appears. For example, there is no Type Node. Yes, that's why I used a `TypeVar`, and made the graph a generic class....

This is what type annotations might look like: https://github.com/networkx/networkx/pull/4014

@fmagin You got it, `typing.Hashable` is the right way. In my pull request, I did want to make sure that `Node` was hashable, which is why I did: ```python Node...

I love this and hope the networkx team will as well. > enforcing return types that subclass dict FYI I think this (and the various comments in the code) should...

This works on 3.7+. It can be fixed for 3.6, but there's no point in doing the work unless this will be accepted soon.

Thank you very much for taking a look at this! > I can't imagine my undergraduates just out of a second course in Python reading through this code and understanding...

> Is this what allows you to do Graph[Node] Yes, exactly. > Is Graph a class or a type or both? I wasn't totally sure myself, but does this help?...

Okay, thanks for clarifying. I took the liberty of reverting my changes to these functions for the time being. Here's a comparison class variable functions with member variable functions, and...

So what's the plan with this? It would be nice not to have to rebase continuously or redo this work years later :)