David Wallace

Results 87 comments of David Wallace

we need to check if the changes to translations in the migration files require new migrations.. and now the `dev-2.2.0` related branches need to be rebased to this new `main`...

do you not want to have any tests for this? For example in here: https://github.com/rdmorganiser/rdmo/blob/dd3cb84d6d40f2a8ec720884b3c2eb69eec10dea/rdmo/questions/tests/test_viewset_catalog.py#L241 ?

yes a general test is there, I mean testing for the specific content of the exported xml (which attributes should be in there..)

do Options also need to remove `conditions`?

we could fix some or most part of the bugs in the View in a meeting, here is a short overview: * in some cases, the "None" should not be...

the whole if-block of `{% if security_measures|is_not_empty %}` should be skipped if there are no answers/non-empty-values given in the dataset that is why it's there... more explicit: `{% if security_measures|is_not_empty...