David Wallace

Results 87 comments of David Wallace

- [x] think that the `additional_input` field on `option` still has problem, it should show `[+] text` here ![image](https://github.com/rdmorganiser/rdmo/assets/13996213/2371f53b-cbf2-4625-b766-9eb25e49f8e6)

> Can you change this ![image](https://private-user-images.githubusercontent.com/1799675/336401208-a38f8cfa-aef9-4b4b-b421-e94d04f5ceb4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTc0OTUzNjksIm5iZiI6MTcxNzQ5NTA2OSwicGF0aCI6Ii8xNzk5Njc1LzMzNjQwMTIwOC1hMzhmOGNmYS1hZWY5LTRiNGItYjQyMS1lOTRkMDRmNWNlYjQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDYwNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA2MDRUMDk1NzQ5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ODRhODMwNmYwYmQ5OTRiZDgyMGU1NTViNDdhZjU1MjBhMjFkMDA2YWRhMzEwNjFkZjA4NjZmZmZmYzYwYzlkNCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.OOO5OEY8xEAxdVx0pKggNXVE4iilI1wRlOV7QbCyOwc) > > ``` > Select all > Select changed > Deselect all > Deselect changed > ``` > > Same for show. (I think...

I have one question about switching language/translations during import. It currently resets the page back to management (cancels the current import). How could I prevent this and just switch language...

- [x] the URIs for Attributes are not properly built at import (as shown in the `CodeLink` ) ![image](https://github.com/rdmorganiser/rdmo/assets/13996213/0ddd92fa-b6b1-4e46-adec-4a9deaf2ac44) * fixed ![image](https://github.com/rdmorganiser/rdmo/assets/13996213/347a281a-ab87-42ac-b268-cf1967cd4297)

Front-end - [x] update some things in the `ImportSuccessElement` - [x] pass importAction - [x] fix EditLink - [x] fix the placement of Warnings and Errors inside the panels -...

I've implement the last todos (https://github.com/rdmorganiser/rdmo/pull/810#issuecomment-2155083683) and pasted in the current [screenshot ](https://private-user-images.githubusercontent.com/13996213/340241837-e5fcb01c-bc8e-4c86-9b89-4318fd015c47.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTg2MTQ4MTAsIm5iZiI6MTcxODYxNDUxMCwicGF0aCI6Ii8xMzk5NjIxMy8zNDAyNDE4MzctZTVmY2IwMWMtYmM4ZS00Yzg2LTliODktNDMxOGZkMDE1YzQ3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MTclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjE3VDA4NTUxMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTVjNzY5OTc3M2ZhNTc2MWVmM2RmYzBiNmEyZjkzNzI0NmIxMDRiZTliYTZjNmRhMDQxZDNhMWQxMTU5YTkxYzcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.6SfK2ZQqD83cbtcjIsCTaLgA5eJz_WZsA49zQy0WB74) Hopefully this is ready by now. Tests could still be extended for the m2m cases...

ESlint could be updated and pinned to 8.56.0

need to align package_json_versions = {'eslint': '8.54.0', 'eslint-plugin-react': '7.34.0', 'react': '18.2.0'} pre_commit_config_versions = {'eslint': '8.54.0', 'eslint-plugin-react': '7.33.2', 'react': '18.2.0'}

yes thanks, it makes sense to have this but was also surprised by this hacky test ;)