David Wallace

Results 87 comments of David Wallace

I get this warning message in the browser when I browse `/projects/`: ```js Warning: Modal uses the legacy childContextTypes API which is no longer supported and will be removed in...

I found a minor issue with icon colors in the management. Are these colors because of my faulty css variables or because of some missing css classes in the react...

I could look at it tomorrow as well, the leftover PRs are ready for review https://github.com/rdmorganiser/rdmo/pulls?q=is%3Aopen+is%3Apr+milestone%3A%22RDMO+2.2.0%22

yes, think it's fine. We have a custom version of the `rdmo/core/templates/core/base_navigation.html` in most cases anyways. * https://github.com/rdmorganiser/rdmo/blob/35a576b9c537a8355229dee4b55484cd997da441/rdmo/core/templates/core/base_navigation.html

Is there still any reason for this change request? Regular single site instances also have `SITE_ID = 1` anyways Would it require changes in the rules backend? please clarify or...

I've had something similar like this when testing out an older existing project in 2.1.2. I thought there was something wrong with the project or catalog because I could not...

In https://github.com/rdmorganiser/rdmo/blob/main/rdmo/projects/validators.py#L32 I get `serializer.instance` is `None` but `serializer.context['view'].request.data.get('changed')` is `True` for a certain checkbox question. Maybe it gets the wrong `collection_index`?

So in previous versions it could happen that a value for one checkbox would be stored twice? This depended then on the catalog/question? As an instance admin, how can I...

I could reproduce this bug or behaviour. Only after switching the Catalag in a Project (and answering a checkbox question with the same Attribute) I got the `"conflict"` validation error...

I'm trying to figure this bug out, but am not sure where the source is.. In the interview, after I've answered a checkbox question and switched catalog. I get the...