David Wallace

Results 87 comments of David Wallace

do we want fix the style on these? Or just ignore those? * UP031: https://docs.astral.sh/ruff/rules/printf-string-formatting/ PS Was already discussed here: https://github.com/rdmorganiser/rdmo/pull/664#discussion_r1297434562 , maybe ignore for now.. Could add to pyproject.toml:...

I would like to have this branch merged first in dev-2.2.0 so that the dev-2.2.0-feature-branches can be rebased to it and can then be tested with all updates (locally or...

ok thanks! This one looks now rebase-and-mergable to me 😅 the screenshot from the CI looks fine to me

@jochenklar still pending for review? - [ ] or ok to merge?

there is new release of `rules`, should I add it here? https://github.com/dfunckt/django-rules/releases/tag/v3.4.0

rebased to 2.1.2 at https://github.com/rdmorganiser/rdmo/pull/892/commits/2dbdb49004ba05e66ef7d935eef99b61b62dbb54

rebased to main at 14f94ed86f331241ae0e911c0104cd1dad871782 but a test ~is failing~ needed to re-run test: * https://github.com/rdmorganiser/rdmo/actions/runs/7552905417/job/20562691026?pr=878#step:8:634 > FAILED rdmo/projects/tests/test_viewset_project_snapshot.py::test_delete[7-1-guest-guest] - assert False > + where False = () > "config.settings">.MEDIA_ROOT...

needed to rebase on main because of changes to `rdmo/core/templates/core/home_text_en.html`

thanks for the cherry pick 🙏, should we set this PR to "ready for review" so that potential conflicts to main already become visible?

screenshots after merge and tests of import feature look fine 👍