oui icon indicating copy to clipboard operation
oui copied to clipboard

Published 20 hours ago • verified publisher icon opensearch-project

[Code cleanup] Clean up new code for breadcrumb updates

Open kavilla opened this issue 2 years ago • 6 comments

Arguably this can be cleaned up a little for the sake of readability and stability: https://github.com/opensearch-project/oui/pull/131/files#r1043950226 https://github.com/opensearch-project/oui/pull/131/files#r1043973824

Please feel free to close this issue if no plan to fix.

kavilla avatar Feb 21 '23 21:02 kavilla

@BSFishy Can we close this, or are there still action items here?

joshuarrrr avatar Oct 05 '23 00:10 joshuarrrr

@BSFishy, @joshuarrrr do you need help on this issue? I can take a look at it if necessary. Or it is already solved?

BigSamu avatar Oct 09 '23 16:10 BigSamu

do you need help on this issue? I can take a look at it if necessary. Or it is already solved?

It looks like #732 took a crack at it, but didn't finish. So you can take this one, if you're interested

BSFishy avatar Oct 09 '23 22:10 BSFishy

OK, you can give me it. I will start looking it!

BigSamu avatar Oct 10 '23 09:10 BigSamu

@joshuarrrr @BSFishy taking a look at this issue now. Sorry for the delay.

BigSamu avatar Nov 01 '23 23:11 BigSamu

@joshuarrrr, @BSFishy PR #1144 was recently created to address this issue. Looking forward to your review.

BigSamu avatar Nov 05 '23 22:11 BigSamu