Ilya Salauyeu

Results 74 comments of Ilya Salauyeu

@tyranron to be able to call `.attach(...)` we need something to call in on. And this is a great opportunity to redo some stuff about how we extract arguments in...

@tyranron > Could you sketch how it should look with .attach() usage? ```rust #[given("...")] fn step(w: &mut World, cucumber::Extract(context): cucumber::Extract(cucumber::Context)) { context.attach(...) } ``` > Actually, I don't understand here,...

Also we should provide `cucumber::Context` for before and after hooks

@tyranron > What do you think on that? I don't like the idea of making `Context` generic over `World`/`Scenario`/`Step`. I see it as a confusing way to hide complexity. `cucumber::Context`...

@tyranron > If we put the mutable cucumber::Context into play, we should make either both via &mut, or both interior mutable. I don't quite understand this point. The way I...

@aslakhellesoy my implementation may be incompatible with test suit in this repository. As I could see tests under `parser` directory parse nested optionals just find and error only on expansion...

@aslakhellesoy > it would be possible to make your implementation compatible with the official test suite Yes, but it would introduce some performance overhead, which we would like to avoid....

@mpkorstanje > typical error messages from a parser are incomprehensible Yes, but only if you are using some sort of parser-generator. [Rust implementation][1] has exactly the same errors, which can...

@mpkorstanje > No. If we only have a formal specification without a closely matching implementation and test set in this repository we are only going to see uncontrolled drift. It...