Ilya Salauyeu

Results 74 comments of Ilya Salauyeu

## FCM ``` Error on invalid `#[display(...)]` arguments (#185, #184) ```

@tyranron should we add [`trybuild`](https://docs.rs/trybuild/1.0.56/trybuild/) to test invalid inputs?

Thanks for the workaround! Maybe we can add `wasm-bindgen` feature for `uuid` based on target right in this repo and also add `wasm` build on the CI? I'll be happy...

@rimutaka > I'm very skeptical to what you've described. I pretty much agree. Working with numbers in Rust maybe painful sometimes, but it provides more safety guarantees and makes you...

@rimutaka yep, there is an example inside crates integration tests: https://github.com/graphql-rust/juniper/blob/3a70403aba7a74652036b74f1db43fc0cfb6bb55/integration_tests/juniper_tests/src/custom_scalar.rs#L135-L156

@rimutaka yes, this is possible, but looks like not documented well enough unfortunately. All derive macros use `#[graphql(...)]` attributes that should pretty much mirror attribute macros. So the solution to...

@rimutaka can you please describe what exactly was confusing about the book? Is it wording `Local 'ScalarValue' implementation.`?

@rimutaka > It looked like you completely removed GraphQLScalarValue Yes, because old `GraphQLScalarValue` was corresponding to 2 different features: deriving `ScalarValue` on enums and implementing custom scalar on structs. Now...

@rimutaka as an output type `HashSet` should work just fine, but I'm not sure what the behaviour should be on input. Should `HashSet` just remove duplicates silently or error?