Ilya Salauyeu

Results 74 comments of Ilya Salauyeu

@tyranron should we add this feature as a part of `#[derive(GraphQLInputObject)]` or push users to create another struct with `From` impl? I'm in favour of this, mainly because we already...

@tyranron isn't this request basically the same as https://github.com/graphql-rust/juniper/issues/1055 but with added directive, that should be generated in the output (introspection or GraphQL API definition)?

@tyranron > `@OneOf` seems to not work with `Scalar`s. Looks like `Scalar`s are allowed: https://github.com/graphql/graphql-spec/pull/825 > ## Can this allow a field to accept both a scalar and an object?...

@tyranron sounds like a great idea, until `GraphQL` supports input unions. I'm not sure about `ConvertInput` thought. We can just support `#[derive(GraphQLInputObject)]` on enums, maybe with additional required `#[graphql(to_struct)]` attribute...

@msterny actually I think we can achieve this without any intermediary structs, just using internal machinery. @tyranron I gave a little bit more thought about additional required attribute to avoid...

@tyranron this sounds a lot like [`#[serde(with = "module")]`][1] attribute and looks like a big ergonomic improvement 👍 From what i can tell, there is no way we can exactly...

@JelteF @tyranron I'm not really sure, how to make transition to `Provider` API here. Basically now we have [`provide()`](https://doc.rust-lang.org/nightly/std/error/trait.Error.html#method.provide) method instead of the `backtrace()`, which uses [`Demand`](https://doc.rust-lang.org/nightly/std/any/struct.Demand.html) to provide some...

@tyranron It looks like `thiserror` fixed this issue: https://github.com/dtolnay/thiserror/pull/182 ```rust enum MyError { First(#[error(backtrace)] FirstError), Second { #[error(source)] source: SecondError, #[error(backtrace)] backtrace: Backtrace } } impl Error for MyError {...

@tyranron agreed, I would like for all `derive` macros having exact `std` trait name match.

@Occhioverde > Maybe, in order to avoid confusion in case someone else forgets to implement `juniper::Context`, it should be considered the option to introduce a more explanatory error message as...