Ilya Salauyeu

Results 74 comments of Ilya Salauyeu

@ysulyma `/graphql?query` [should work](https://graphql.org/learn/serving-over-http/#get-request), but [`rocket` example](https://github.com/graphql-rust/juniper/blob/0df1e448e87d6b5f65d16710ca4b05d873459964/juniper_rocket/examples/rocket_server.rs#L14-L21) is incorrect, as it uses `Deserialize` impl of [`GraphQLRequest`](https://docs.rs/juniper/latest/juniper/http/struct.GraphQLRequest.html). We'll address this in `0.16` release. Until then you have 2 options: 1. Use...

@bbqsrc can you please describe implications of this issue? Are there any `Feature` variants that have troubles while parsing? Or is it just generated `AST` not compliant with official test...

@bbqsrc it looks like it's not a bug, but a feature introduced in [Gherkin 6.0.13][1] 😆 [1]: https://github.com/cucumber/common/blob/main/gherkin/CHANGELOG.md#6013---2018-09-25

@tyranron this will allow to log something in colored mode and with concurrent execution. Logs captured during some `Step` execution will be printed only when this `Step` is actually outputted...

@tyranron from what I can tell, we can easily support this with another `Writer` implementation, as we generate a lot more events, than just `Test(Case/Step)(Started/Finished)`. Those additional events allow us...

@theredfish I do think, that adding retries for flaky tests is a great feature to have, but I have couple concerns about proposed implementation. > ```rust > .replay_failed(2) > ```...

@tyranron I think that reasonable default should be rerunning `Scenario`s immediately. But it would be great to support postponed reruns or even combination of postponed and serial for really flaky...

@theredfish > My bad it wasn't clear enough but my example was about scenarios not steps. Actually `Scenario`s are generally run in parallel, so there is no need for additional...

While implementing retries for failed `Scenario`s I've stumbled upon an inconvenience in the discussed design. In case `Writer` is wrapped into a `Normalize` I expect it to wait on current...

@tyranron > Retrying without giving explicit feedback about it is quite a subtle thing. We better notify explicitly about what's going on. Clear understanding of what's going on is a...