Ikhun Um

Results 191 issues of Ikhun Um

Motivation: Central Dogma does not use Armeria's `LoggingClient`, so known exceptions handled by `HttpApiExceptionHandler` are logged in `DefaultUnloggedExceptionsReporter`. Moditications: - Set `ctx.setShouldReportUnloggedExceptions(false)` to ignore known exceptions they don't need to...

defect

All Central Dogma APIs use JSON (Patch) to exchange data. A Central Dogma server can't handle other types such as XML or YAML. Currently, the request `content-type` is not specified...

defect

``` > Task :xds:shadedTest FAILED XdsRouteServiceTest > initializationError FAILED java.util.concurrent.CompletionException: java.lang.RuntimeException: Failed to start control plane plugin in 60 seconds. at java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:292) at java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:308) at java.util.concurrent.CompletableFuture.uniRun(CompletableFuture.java:714) at java.util.concurrent.CompletableFuture$UniRun.tryFire(CompletableFuture.java:701) at java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:488)...

cleanup

It would be useful especially when we bookmark a Central Dogma web page.

new feature

The URL patterns for UI have been changed for the new web application. It would be nicer if we could provide automatic redirection for some patterns. Good candidates: - Old)...

improvement

Motivation: `ServerErrorHandler.renderStatus()` is used in `DefaultServerErrorHandler` and may not be called in a custom `ServerErrorHandler`. Attempting to inject CORS headers via `CorsServerErrorHandler.renderStatus()` may not work. Modifications: - Use `ctx.mutateAdditionalResponseHeaders()` to...

defect

Motivation: Unfinished requests even after graceful shutdown period are forcivily closed with `ClosedSessionException`. As `ClosedSessionException` indicates that the connection was unexpectedly disconnected, `ClosedSessionException` is not suitable for graceful shutdown. In...

new feature
deprecation

JSON is the dominant exchange format for REST API. However, Armeria's `WebClient` does not provide any JSON-specific APIs. I believe it should be useful additions if we provide: ```java WebClient...

new feature
good first issue

Motivation: There was a bug in `AsyncServerInterceptor` where a `ForwardingServerCall` was not unwrapped properly via reflection. Because of that, OpenTelemetry's `TracingServerCall` that wraps the existing `ServerCall` using `ForwardingServerCall` was rejected...

defect

The title of the documentation service is hard-coded to `Armeria documentation service ` https://github.com/line/armeria/blob/e0192ccbaa01f9c6f03849d4879507d93dc17aa8/docs-client/src/containers/App/index.tsx#L608-L611 Some users may want to override the title to easily distinguish a server from a different...

new feature