Ikhun Um
Ikhun Um
`Change` is a data class that only provides the default constructor. It would be nice to offer various factories for users' convenience as like upstream Central Dogma did. https://github.com/line/centraldogma/blob/ece893db888fbb5c4f1e28987b9aee10d78e5396/common/src/main/java/com/linecorp/centraldogma/common/Change.java#L65
#14 introduced `Query` type. The existing APIs that use a string as a query expression need to be updated such as. https://github.com/line/centraldogma-python/blob/6098f1afe6b181388ab32bd7f91161dd7bd2a70d/centraldogma/content_service.py#L44 https://github.com/line/centraldogma-python/blob/6098f1afe6b181388ab32bd7f91161dd7bd2a70d/centraldogma/query.py#L30-L45
Currently, a revision is represented as an int. https://github.com/line/centraldogma-python/blob/6098f1afe6b181388ab32bd7f91161dd7bd2a70d/centraldogma/dogma.py#L140 It would be nice to use a dedicated type introduced in #14 https://github.com/line/centraldogma-python/blob/6098f1afe6b181388ab32bd7f91161dd7bd2a70d/centraldogma/data/revision.py#L20-L34
README.md could be a gentle guide for users to start centraldogma-python for the first time. Examples: https://github.com/line/centraldogma-go https://github.com/line/centraldogma-rs
A directory can be downloaded with #49. It would also be helpful to support uploading a directory. A recursive download can be used to backup a Central Dogma directory and...
Motivation: Armeria does not automatically delete the uploaded files, so users should manually remove the temporary files themselves. It would be useful if we provided some options for how to...
One `DistributionStatisticConfig` is shared to configure both `Timer` and `DistributionSummary`. This limitation prevents users from being able to customize Armeria meters with various options. Users may want to configure different...
When files are uploaded to an Armeria server with `multipart/form`, it is stored to `multipartUploadsLocation()` when `@Param` of annotated services or GraphQL multipart request is used. https://armeria.dev/docs/server-multipart#using-typeparam-annotation https://github.com/line/armeria/blob/0a5a3d7a2f74f51a4893270a6f4aeac5f7e3c575/graphql-protocol/src/main/java/com/linecorp/armeria/server/graphql/protocol/AbstractGraphqlService.java#L101-L103 As Armeria...
`defaultUseHttp2Preface` has only `true` and `false` options and does not tell which protocols HTTP/2 connection preface should be used for. Currently, the option is applied to both `http` and `h2c`....
We don't have documentation for the OAuth 2.0 client. Users should rely on Javadoc and test code to use it. It would be good to write documentation for OAuth 2.0....