Ikhun Um
Ikhun Um
https://github.com/line/armeria/pull/5718#discussion_r1625829784 > @minwoox wrote: > I think we can probably do it when we reach 2.0: > Move ServerBuilder.DEFAULT_GRACEFUL_SHUTDOWN_TIMEOUT to Flags > Increase ServerBuilder.DEFAULT_GRACEFUL_SHUTDOWN_TIMEOUT value from zero > Use the...
Motivation: Related: #5708, #4834 If a decorator directly returns a response, the `RequestLog` for the request won't be complete. Because the `RequestLog` is automatically completed when it starts to be...
`:` is useful to bind a path variable. However, `:` is a variable character for a path. If a path variable `:foo` is mixed with a literal `:`, it is...
If a decorator inside `RetryingClient` directly returns a failed response, it may not complete `RequestLog`. A `RetryingClient` that waits for the log to be completed will be hanged. https://github.com/line/armeria/blob/01f2c6f6ee49548c499b202be50fc9d3df84dd4f/core/src/main/java/com/linecorp/armeria/client/retry/RetryingClient.java#L375-L379 I...
Because WebSocket is mostly a long-running request, it is not easy to limit when it will end with a request timeout. It would make more sense to terminate the request...
Javadoc of `addAdditionalResponsHeaders(...)` states that it adds the specified headers that will be included in response headers. https://github.com/line/armeria/blob/d48d5fa5c0e30f34deac6df1ada7e41b58ae444c/core/src/main/java/com/linecorp/armeria/server/ServiceRequestContext.java#L547-L551 But it does not specify what happens if the same header name...
It would be useful if a Central Dogma client has an option to automatically retry a failed request. If a Central Dogma cluster is rolling restarted, a client may receive...
Motivation: Invalid authorization is a client error so there isn't much a server maintainer can do. It seems better to use `DEBUG` to detect problems during development. `WARN` could be...
If Project Loom is activated on the JRE, we may use `Thread.ofVirtual().factory()` to create virtual threads for `BlockingTaskExecutor` instead. https://github.com/line/armeria/blob/d3c3811d7367e67ed4b7df47aa9fad5889948aed/core/src/main/java/com/linecorp/armeria/common/util/BlockingTaskExecutorBuilder.java#L131-L135 Virtual threads require a small number of threads. Users will...
Armeria annotated services use an (service) event loop by default if `@Blocking` or `.useBlockingTaskExecutor(true)` is not set. I think we can improve the static default value to dynamically determine if...