Igromanru
Igromanru
In case you're still working on it. Want to report my initial feedback. First thing that I've noticed that simply using the build from this branch with all my mods...
> I suspect any issues with it would most likely be from weird race conditions due to it being much faster. Ideally we'd somehow pull back in the lua jit/sol...
It would be nice if the PR would be merged after #675.
> I'm not sure if IsPlayerController() has always existed and it also only returns true if the class is a PlayerController, so it will never return true if this falls...
> > Considering we're checking for `Controller`, not just `PlayerController`, should we even have the `IsPlayerController` check ? Doesn't that check make the inclusion of finding just `Controller` irrelevant since...
To be honest, I doubt that current UE4SS supports 10 old Unreal Engine versions. I just downloaded the game [Daylight](https://store.steampowered.com/app/230840/Daylight/). No idea which UE4 version it has exactly, but a...
[Kholat](https://store.steampowered.com/app/343710/Kholat/) UE v4.7.5.3 ``` [2024-10-04 19:26:12.8362075] PS Scan attempt 1 [2024-10-04 19:26:12.8362403] [PS] Reading image [2024-10-04 19:26:12.8363193] [PS] Starting scan [2024-10-04 19:26:12.9072915] [PS] Scan finished in 70.9423ms [2024-10-04 19:26:12.9073172] [PS]...
> It says in the readme the versions we support and PS scans aren't related to support If PS doesn't support a game, it means that UE4SS doesn't work out...
> I think if no game can be found to test with, we should merge this and fix any potential problems in the future if this change is actually found...
Over a week hast past. Any news here? I've so far reviews UEHelpers once again and found no logic errors.