ickshonpe

Results 158 comments of ickshonpe

Actually, I guess it should be done either way.

> If we remove this feature gate doesn’t this mean I can’t compile out this dev/debug feature in my release builds? > > Edit: For my own part I'd prefer...

> Makes sense to me. Thanks for including the traces, seems like a pretty big win. The benchmark is very synthetic, most applications aren't going to redraw multiple pages of...

### Inset box shadows I only included drop shadow support as I wanted to keep the initial PR really simple but inset shadows should be really easy to add. If...

Multiple shadow support #16502

> I like this as an incremental move forward. We shouldn't be storing a full `Transform` here, but that's easy to migrate from this PR. > > Should this be...

> This does seem like the least-bad option. But I thought there was code in `bevy_transform` to specifically filter out ui elements from propagation. Could you check if that's still...

> @ickshonpe I'm really keen on this as a step towards the great transform splittification :) Is this ready for review? Probably, I'll take another look at this first thing...

> Looks ok. I'm not sold on the transform as field in `ComputedNode` but I'm not sold either on any alternative. > Yeah I don't know either. I did it...

@alice-i-cecile I think this is more or less good enough now. Abandoned the weird ideas I had, just got a `UiTransform` component that replaces `Transform`. I wanted to keep this...