ickshonpe

Results 158 comments of ickshonpe

The way the constraints data is structured seems wrong to me. In Flex you usually access the constraints one axis at a time but the current API makes that awkward...

I understand what alt text is but I haven't looked at the AccessKit pr before today and I don't understand the intent behind this implementation. With `TextStyle::default()` no text is...

I've only been looking at the accessibility module for a few minutes so this might be nonsense, but would a change something like this be acceptable: ```rust #[derive(Component)] pub struct...

For the moment, I've constrained the Image to a fixed size so it will display correctly with the text as a child.

Had some further thoughts about this: * Perhaps another option for alt-text might be for assets to have an optional description string? Then users could add a description to media...

> You say > > > I've replaced the ImageBundle with a NodeBundle that has a white background color and a UiImage component, and added a comment explaining why. I...

Not really, in main atm UI benchmarks aren't very meaningful because the rendering is so slow and in `ui_layout_system` we always update all the layout geometry every frame even when...

I should have been clearer as well, the point of this PR isn't to improve performance. It's about the undesirability of having a mini layout algorithm running in extraction to...

I think that having distinct components for each different layout output value is probably untenable. It would be more ergonomic to have the computed values for border thickness, border radius,...

Being able to split up the documentation is really nice I think. I'm not quite sure whether it's better to use traits or macros to implement the common functions. I...