Hoang Quoc Trung comments

Results 7 comments of


                                            Hoang Quoc Trung

Implement Application Default Credentials for the google connector

Thanks for the review @nabokihms and sorry for the delay, I've added the warning log as well as some unit tests for the logic. Regarding the unit test implementation, I've...

Implement Application Default Credentials for the google connector

There's no problem regarding the delay. My PR updates are also extremely delayed 😅

fix for issue 2670; check for no serviceAccountFilePath and no email

The PR LGTM @nabokihms

Fix Google connector ADC implementation within GKE environments

@nabokihms during my initial tests it worked on GKE. However, I realized when the issue was submitted that I had a residual json key in the container which was picked...

Google connector with ADC: unexpected end of JSON input

I think I might have isolated the issue with the code (upon further testing in a GKE cluster) and its with this line: https://github.com/dexidp/dex/blob/master/connector/google/google.go#L300 The default behavior for the [google.FindDefaultCredentials](https://pkg.go.dev/golang.org/x/oauth2/google#FindDefaultCredentials)...

[WIP] Add redis beta scheduled snapshot

Thanks for the review @rileykarson and sorry for the multiple changes required as I'm not familiar with the default handling in the magic-modules 😅

Made cloud identity groups updatable and updated documentation

@melinath Any updates on this PR? It would be really nice to have security group labels for Cloud Identity groups. On an unrelated note, for the race condition / flaky...