dex icon indicating copy to clipboard operation
dex copied to clipboard

Published 20 hours ago • verified publisher icon dexidp

fix for issue 2670; check for no serviceAccountFilePath and no email

Open bobcallaway opened this issue 2 years ago • 4 comments

Overview

This (hopefully) reverts a bug introduced in #2530 which does not handle the case where application default credentials nor a service account file (containing credentials) are needed to operate a Google connector.

What this PR does / why we need it

Fixes: #2670

Special notes for your reviewer

Does this PR introduce a user-facing change?

NONE

fixes regression for Google connector when used without groups

Signed-off-by: Bob Callaway [email protected]

@ichbinfrog

bobcallaway avatar Sep 22 '22 19:09 bobcallaway

@bobcallaway Thanks! I think we can make a patch release with this fix, but there is a test that is failing.

nabokihms avatar Sep 23 '22 06:09 nabokihms

@bobcallaway Thanks! I think we can make a patch release with this fix, but there is a test that is failing.

just noticed that and updated the fix to check if a connector has any groups specified before trying to create the directory service.

bobcallaway avatar Sep 23 '22 10:09 bobcallaway

LGTM

@ichbinfrog , do you have to add something (as the original author of the feature)?

nabokihms avatar Sep 23 '22 12:09 nabokihms

The PR LGTM @nabokihms

ichbinfrog avatar Sep 24 '22 19:09 ichbinfrog

No, everything is fine.

nabokihms avatar Sep 28 '22 17:09 nabokihms