[WIP] Add redis beta scheduled snapshot

[ichbinfrog]

Adds scheduled rdb snapshot for redis instances (see related beta API reference)

If this PR is for Terraform, I acknowledge that I have:

• [x] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• [x] Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• [x] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• [ ] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• [x] Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

redis: Added field `persistence_config` to `google_redis_instance` (beta)

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@rileykarson, please review this PR or find an appropriate assignee.

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 79 insertions(+)) Terraform Beta: Diff ( 3 files changed, 301 insertions(+)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-)) TF OiCS: Diff ( 4 files changed, 132 insertions(+))

[modular-magician]

Tests analytics

Total tests: 1990 Passed tests 1739 Skipped tests: 240 Failed tests: 11

Action taken

Triggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccFirebaserulesRelease_BasicRelease|TestAccRedisInstance_redisInstanceMrrExample|TestAccRedisInstance_redisInstanceFullExample|TestAccRedisInstance_redisInstanceAuthEnabled|TestAccRedisInstance_downgradeRedisVersion|TestAccRedisInstance_regionFromLocation|TestAccRedisInstanceDatasource_basic|TestAccRedisInstance_update|TestAccRedisInstance_redisInstanceScheduledRdbSnapshotExample|TestAccRedisInstance_redisInstanceBasicExample|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic

[modular-magician]

Tests passed during RECORDING mode: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic[view] TestAccFirebaserulesRelease_BasicRelease[view]

Tests failed during RECORDING mode: TestAccRedisInstance_redisInstanceScheduledRdbSnapshotExample[view] TestAccRedisInstance_downgradeRedisVersion[view] TestAccRedisInstance_redisInstanceAuthEnabled[view] TestAccRedisInstance_regionFromLocation[view] TestAccRedisInstance_update[view] TestAccRedisInstance_redisInstanceBasicExample[view] TestAccRedisInstance_redisInstanceMrrExample[view] TestAccRedisInstance_redisInstanceFullExample[view] TestAccRedisInstanceDatasource_basic[view]

Please fix these to complete your PR View the build log or the debug log for each test

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 80 insertions(+)) Terraform Beta: Diff ( 3 files changed, 303 insertions(+)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-)) TF OiCS: Diff ( 4 files changed, 132 insertions(+))

[modular-magician]

Tests analytics

Total tests: 1989 Passed tests 1739 Skipped tests: 240 Failed tests: 10

Action taken

Triggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccRedisInstanceDatasource_basic|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccRedisInstance_regionFromLocation|TestAccRedisInstance_downgradeRedisVersion|TestAccRedisInstance_redisInstanceScheduledRdbSnapshotExample|TestAccRedisInstance_update|TestAccRedisInstance_redisInstanceMrrExample|TestAccRedisInstance_redisInstanceAuthEnabled|TestAccRedisInstance_redisInstanceBasicExample|TestAccRedisInstance_redisInstanceFullExample

[modular-magician]

Tests passed during RECORDING mode: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic[view]

Tests failed during RECORDING mode: TestAccRedisInstance_update[view] TestAccRedisInstance_downgradeRedisVersion[view] TestAccRedisInstance_redisInstanceAuthEnabled[view] TestAccRedisInstance_regionFromLocation[view] TestAccRedisInstance_redisInstanceFullExample[view] TestAccRedisInstance_redisInstanceScheduledRdbSnapshotExample[view] TestAccRedisInstance_redisInstanceMrrExample[view] TestAccRedisInstance_redisInstanceBasicExample[view] TestAccRedisInstanceDatasource_basic[view]

Please fix these to complete your PR View the build log or the debug log for each test

[rileykarson]

RECORDING failures are due to issues in our CI right now, not this PR necessarily. I'm working on fixing those to unblock reviews.

[rileykarson]

/gcbrun

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 80 insertions(+)) Terraform Beta: Diff ( 3 files changed, 303 insertions(+)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-)) TF OiCS: Diff ( 4 files changed, 132 insertions(+))

[modular-magician]

Tests analytics

Total tests: 1990 Passed tests 1741 Skipped tests: 240 Failed tests: 9

Action taken

Triggering VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccRedisInstance_update|TestAccRedisInstance_redisInstanceScheduledRdbSnapshotExample|TestAccRedisInstance_redisInstanceMrrExample|TestAccRedisInstance_redisInstanceFullExample|TestAccRedisInstance_redisInstanceBasicExample|TestAccRedisInstanceDatasource_basic|TestAccRedisInstance_redisInstanceAuthEnabled|TestAccRedisInstance_downgradeRedisVersion|TestAccRedisInstance_regionFromLocation

[modular-magician]

Tests failed during RECORDING mode: TestAccRedisInstanceDatasource_basic[view] TestAccRedisInstance_update[view] TestAccRedisInstance_downgradeRedisVersion[view] TestAccRedisInstance_redisInstanceAuthEnabled[view] TestAccRedisInstance_regionFromLocation[view] TestAccRedisInstance_redisInstanceMrrExample[view] TestAccRedisInstance_redisInstanceScheduledRdbSnapshotExample[view] TestAccRedisInstance_redisInstanceFullExample[view] TestAccRedisInstance_redisInstanceBasicExample[view]

Please fix these to complete your PR View the build log or the debug log for each test

[rileykarson]

Sorry for the delay in getting back! I generally respond when generate-diffs or the VCR tests finish, and it failed due to a conflict. Are you able to rebase on top of HEAD?

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 79 insertions(+), 10 deletions(-)) Terraform Beta: Diff ( 3 files changed, 296 insertions(+), 5 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-)) TF OiCS: Diff ( 4 files changed, 132 insertions(+))

[modular-magician]

Tests analytics

Total tests: 2029 Passed tests 1792 Skipped tests: 226 Failed tests: 11

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccRedisInstance_redisInstanceAuthEnabled|TestAccRedisInstance_downgradeRedisVersion|TestAccRedisInstance_regionFromLocation|TestAccRedisInstance_updateReadReplicasModeWithAutoSecondaryIp|TestAccRedisInstance_redisInstanceScheduledRdbSnapshotExample|TestAccRedisInstance_updateReadReplicasMode|TestAccRedisInstance_update|TestAccRedisInstance_redisInstanceMrrExample|TestAccRedisInstance_redisInstanceBasicExample|TestAccRedisInstance_redisInstanceFullExample|TestAccRedisInstanceDatasource_basic

[modular-magician]

Tests failed during RECORDING mode: TestAccRedisInstanceDatasource_basic[view] TestAccRedisInstance_updateReadReplicasMode[view] TestAccRedisInstance_downgradeRedisVersion[view] TestAccRedisInstance_redisInstanceAuthEnabled[view] TestAccRedisInstance_regionFromLocation[view] TestAccRedisInstance_updateReadReplicasModeWithAutoSecondaryIp[view] TestAccRedisInstance_redisInstanceMrrExample[view] TestAccRedisInstance_update[view] TestAccRedisInstance_redisInstanceScheduledRdbSnapshotExample[view] TestAccRedisInstance_redisInstanceFullExample[view] TestAccRedisInstance_redisInstanceBasicExample[view]

Please fix these to complete your PR View the build log or the debug log for each test

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 79 insertions(+), 10 deletions(-)) Terraform Beta: Diff ( 3 files changed, 295 insertions(+), 5 deletions(-)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-)) TF OiCS: Diff ( 4 files changed, 132 insertions(+))

[modular-magician]

Tests analytics

Total tests: 2031 Passed tests 1714 Skipped tests: 226 Failed tests: 91

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccRedisInstance_downgradeRedisVersion|TestAccRedisInstance_redisInstanceAuthEnabled|TestAccRedisInstance_regionFromLocation|TestAccRedisInstance_updateReadReplicasModeWithAutoSecondaryIp|TestAccRedisInstance_updateReadReplicasMode|TestAccRedisInstance_update|TestAccRedisInstance_redisInstanceScheduledRdbSnapshotExample|TestAccRedisInstance_redisInstanceMrrExample|TestAccRedisInstance_redisInstanceBasicExample|TestAccRedisInstance_redisInstanceFullExample|TestAccContainerNodePool_maxPodsPerNode|TestAccContainerNodePool_nodeLocations|TestAccContainerCluster_updateMaintenanceExclusionOptions|TestAccContainerNodePool_basicWithClusterId|TestAccContainerNodePool_basic|TestAccContainerCluster_withDNSConfig|TestAccContainerCluster_withEnableKubernetesAlpha|TestAccContainerCluster_withMasterAuthorizedNetworksConfig|TestAccContainerCluster_withMasterAuthorizedNetworksDisabled|TestAccContainerCluster_withResourceUsageExportConfig|TestAccContainerCluster_withAdvancedDatapath|TestAccContainerCluster_errorNoClusterCreated|TestAccContainerCluster_withDatabaseEncryption|TestAccContainerCluster_errorCleanDanglingCluster|TestAccContainerCluster_withMaintenanceExclusionOptions|TestAccContainerCluster_nodeAutoprovisioningDefaultsImageType|TestAccContainerCluster_withMaintenanceExclusionWindow|TestAccContainerCluster_withTelemetryEnabled|TestAccContainerCluster_withFlexiblePodCIDR|TestAccContainerCluster_withBinaryAuthorization|TestAccContainerCluster_withAutoscalingProfile|TestAccContainerCluster_withReleaseChannelEnabledDefaultVersion|TestAccContainerCluster_withRecurringMaintenanceWindow|TestAccContainerCluster_withMaintenanceWindow|TestAccContainerCluster_withNodePoolNodeConfig|TestAccContainerCluster_nodeAutoprovisioningDefaultsMinCpuPlatform|TestAccContainerCluster_withReleaseChannelEnabled|TestAccContainerCluster_withSoleTenantGroup|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccContainerCluster_withMasterAuthConfig_NoCert|TestAccContainerCluster_withILBSubsetting|TestAccContainerCluster_withNodePoolMultiple|TestAccContainerCluster_withLoggingConfig|TestAccContainerCluster_withNetworkPolicyEnabled|TestAccContainerCluster_withIdentityServiceConfig|TestAccContainerCluster_withWorkloadIdentityConfig|TestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_errorAutopilotLocation|TestAccContainerCluster_withAutopilot|TestAccContainerCluster_withNotificationConfig|TestAccContainerCluster_withNodePoolAutoscaling|TestAccContainerCluster_withAddons|TestAccContainerCluster_withShieldedNodes|TestAccContainerCluster_misc|TestAccContainerCluster_withNodePoolResize|TestAccContainerCluster_networkingModeRoutes|TestAccContainerCluster_basic|TestAccContainerCluster_nodeAutoprovisioningDefaults|TestAccContainerCluster_withNodePoolUpdateVersion|TestAccContainerCluster_withNodePoolBasic|TestAccContainerNodePool_012_ConfigModeAttr|TestAccContainerCluster_backend|TestAccContainerCluster_withIPAllocationPolicy_specificSizes|TestAccContainerCluster_withIPAllocationPolicy_specificIPRanges|TestAccContainerCluster_network|TestAccContainerCluster_withIPAllocationPolicy_existingSecondaryRanges|TestAccContainerCluster_withBootDiskKmsKey|TestAccContainerCluster_withSandboxConfig|TestAccContainerCluster_deleteExclusionWindow|TestAccContainerCluster_withWorkloadMetadataConfig|TestAccContainerCluster_withNodeConfigShieldedInstanceConfig|TestAccContainerCluster_withNodeConfigScopeAlias|TestAccContainerCluster_withNodeConfig|TestAccContainerCluster_updateVersion|TestAccContainerCluster_withVersion|TestAccContainerCluster_withIntraNodeVisibility|TestAccContainerCluster_withPrivateClusterConfigMissingCidrBlock_withAutopilot|TestAccContainerNodePool_withLinuxNodeConfig|TestAccContainerNodePool_withKubeletConfig|TestAccContainerNodePool_withSandboxConfig|TestAccContainerNodePool_withWorkloadIdentityConfig|TestAccContainerCluster_withPrivateClusterConfig|TestAccContainerCluster_deleteMaintenanceExclusionOptions|TestAccContainerCluster_withTpu|TestAccContainerNodePool_withNodeConfig|TestAccContainerCluster_regionalWithNodeLocations|TestAccContainerCluster_regionalWithNodePool|TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigGkeExample|TestAccContainerCluster_regional|TestAccContainerClusterDatasource_regional|TestAccRedisInstanceDatasource_basic

[modular-magician]

The provider crashed while running the VCR tests in RECORDING mode Please fix it to complete your PR View the build log

[ichbinfrog]

Thanks for the review @rileykarson and sorry for the multiple changes required as I'm not familiar with the default handling in the magic-modules 😅

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 78 insertions(+)) Terraform Beta: Diff ( 3 files changed, 296 insertions(+)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-)) TF OiCS: Diff ( 4 files changed, 132 insertions(+))

[modular-magician]

Tests analytics

Total tests: 2035 Passed tests 1796 Skipped tests: 226 Failed tests: 13

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccRedisInstance_downgradeRedisVersion|TestAccRedisInstance_redisInstanceAuthEnabled|TestAccRedisInstance_regionFromLocation|TestAccRedisInstance_updateReadReplicasModeWithAutoSecondaryIp|TestAccRedisInstance_updateReadReplicasMode|TestAccRedisInstance_update|TestAccRedisInstance_redisInstanceScheduledRdbSnapshotExample|TestAccRedisInstance_redisInstanceMrrExample|TestAccRedisInstance_redisInstanceFullExample|TestAccRedisInstance_redisInstanceBasicExample|TestAccRedisInstanceDatasource_basic|TestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_withAddons

[modular-magician]

Tests failed during RECORDING mode: TestAccRedisInstanceDatasource_basic[view] TestAccRedisInstance_update[view] TestAccRedisInstance_downgradeRedisVersion[view] TestAccRedisInstance_redisInstanceAuthEnabled[view] TestAccRedisInstance_regionFromLocation[view] TestAccRedisInstance_updateReadReplicasModeWithAutoSecondaryIp[view] TestAccRedisInstance_updateReadReplicasMode[view] TestAccRedisInstance_redisInstanceFullExample[view] TestAccRedisInstance_redisInstanceScheduledRdbSnapshotExample[view] TestAccRedisInstance_redisInstanceMrrExample[view] TestAccContainerCluster_withConfidentialNodes[view] TestAccRedisInstance_redisInstanceBasicExample[view] TestAccContainerCluster_withAddons[view]

Please fix these to complete your PR View the build log or the debug log for each test

[modular-magician]

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 78 insertions(+)) Terraform Beta: Diff ( 3 files changed, 297 insertions(+)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-)) TF OiCS: Diff ( 4 files changed, 132 insertions(+))

[modular-magician]

Tests analytics

Total tests: 2054 Passed tests 1813 Skipped tests: 226 Failed tests: 15

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccRedisInstance_updateReadReplicasModeWithAutoSecondaryIp|TestAccRedisInstance_regionFromLocation|TestAccRedisInstance_downgradeRedisVersion|TestAccRedisInstance_redisInstanceAuthEnabled|TestAccContainerCluster_withConfidentialNodes|TestAccContainerCluster_withAddons|TestAccRedisInstance_updateReadReplicasMode|TestAccRedisInstance_update|TestAccSqlUser_mysqlDisabled|TestAccRedisInstance_redisInstanceScheduledRdbSnapshotExample|TestAccRedisInstance_redisInstanceMrrExample|TestAccRedisInstance_redisInstanceFullExample|TestAccFirebaserulesRelease_BasicRelease|TestAccRedisInstance_redisInstanceBasicExample|TestAccRedisInstanceDatasource_basic

[modular-magician]

Tests passed during RECORDING mode: TestAccRedisInstanceDatasource_basic[view] TestAccRedisInstance_update[view] TestAccSqlUser_mysqlDisabled[view] TestAccRedisInstance_downgradeRedisVersion[view] TestAccRedisInstance_redisInstanceAuthEnabled[view] TestAccRedisInstance_regionFromLocation[view] TestAccRedisInstance_updateReadReplicasModeWithAutoSecondaryIp[view] TestAccRedisInstance_updateReadReplicasMode[view] TestAccRedisInstance_redisInstanceBasicExample[view] TestAccRedisInstance_redisInstanceMrrExample[view] TestAccRedisInstance_redisInstanceFullExample[view] TestAccFirebaserulesRelease_BasicRelease[view]

Tests failed during RECORDING mode: TestAccRedisInstance_redisInstanceScheduledRdbSnapshotExample[view] TestAccContainerCluster_withConfidentialNodes[view] TestAccContainerCluster_withAddons[view]

Please fix these to complete your PR View the build log or the debug log for each test