Ibraheem Ahmed

Results 207 comments of Ibraheem Ahmed

For specific types the load granularity can be larger than a byte and we will likely want to take advantage of that, so the name `AtomicPerByte` might not fit well.

I think escaping with `\` makes sense. `/prefix:parameter` is accepted by matchit, which makes the second option more difficult.

Seems it's not only an underscore that causes an issue, any character after the matching prefix causes a false positive in the check [here](https://github.com/ibraheemdev/matchit/blob/master/src/tree.rs#L508).

I would guess v8 is optimizing the code and executing it at compile-time (the same program with a console.log is similarly fast). Quickjs runs it on my machine in 1.071...

Sorry, I didn't get notified that you made the change. Just one small nit before merging.

As @theduke mentioned, it would be nice if diesel provided callbacks (like active record) for other crates to hook into: ```rust trait Connection { fn before_commit(&mut self, hook: impl Fn(...));...