Ibraheem Ahmed

Results 207 comments of Ibraheem Ahmed

I'm not really familiar with fiber and fasthttp. I opened up an issue there (gofiber/fiber#943), hopefully they can help you out

GitHub cannot do this automatically (isaacs/github#215) so we can use a tool like [github-markdown-toc](https://github.com/ekalinin/github-markdown-toc).

Would: ```rust fn routes(&self) -> impl Iterator; fn routes_mut(&mut self) -> impl Iterator; ``` Work for your use case?

I would like to provide the routes as well. I think the best way to do this would be to store a list of full paths and indices at the...

I'm thinking something like: ```rust pub struct Root { node: Node, // a list of prefixes, and nested indices paths: Vec } impl Root { // this would really be...

Your code aliases a `Box`, which is UB. You could do this with `NonNull`, but I would prefer the index-based solution.

Oddly, this passes: ```rust #[test] fn test_non_ascii() { let mut tree = Node::new(); tree.insert("x:x", ()); tree.path_ignore_case("/£", false); } ```

This was for `/foo/` matching and insert conflict handling, but it can probably be removed with a couple tweaks.

This was changed in #19.

This would be a pretty fundamental change to the router. For fallback routing I was thinking of supporting a much simpler model, where conflicting inserts would return the conflicting value....