awaitgroup icon indicating copy to clipboard operation
awaitgroup copied to clipboard

use AtomicWaker instead of Mutex<Option<Waker>>

Open cfeitong opened this issue 3 years ago • 1 comments

futures crate provides a useful synchronization primitive AtomicWaker. I think it is a better choice over Mutex<Option<Waker>>.

cfeitong avatar Feb 14 '22 05:02 cfeitong

Sorry for the late review, I don't want to pull in the entire futures crate for this, could you update the code to depend on the atomic-waker crate instead?

ibraheemdev avatar Feb 27 '22 02:02 ibraheemdev

@ibraheemdev friendly ping.

chen-hongzhi avatar Oct 13 '22 12:10 chen-hongzhi

Sorry, I didn't get notified that you made the change. Just one small nit before merging.

ibraheemdev avatar Oct 13 '22 18:10 ibraheemdev

Thanks!

ibraheemdev avatar Oct 13 '22 19:10 ibraheemdev