awaitgroup
awaitgroup copied to clipboard
use AtomicWaker instead of Mutex<Option<Waker>>
futures
crate provides a useful synchronization primitive AtomicWaker
. I think it is a better choice over Mutex<Option<Waker>>
.
Sorry for the late review, I don't want to pull in the entire futures crate for this, could you update the code to depend on the atomic-waker
crate instead?
@ibraheemdev friendly ping.
Sorry, I didn't get notified that you made the change. Just one small nit before merging.
Thanks!