Ibraheem Ahmed

I'm not sure we should be touching `Vec::push` here.. maybe just duplicate the implementation?

I'm happy to review `Vec::insert_mut` along with this PR, but also fine to merge after the review comment is addressed.

Yeah that seems reasonable, I think we can support it.

I updated the implementation to support overlapping suffixes, such as `/foo`, `/{foo}.jpg`, and `/{foo}.png`. This does impose a very minor performance regression by introducing an extra node after any route...

Not sure if something changed recently but I'm getting `thread 'Worker' panicked at crates/hir-ty/src/diagnostics/match_check/pat_analysis.rs:401:21:\ninternal error: entered unreachable code: Unexpected type for `Struct` constructor: AssocTypeId(8088)` very consistently immediately after opening certain...

On my machine the downloads complete in 3m 18s. We are definitely downloading in parallel, I can see the progress running from the https://github.com/astral-sh/uv/pull/3252 branch. @messense can you provide the...

@messense Here's the progress output: https://github.com/astral-sh/uv/assets/34988408/26b288de-d17a-4544-bfa5-c993529e8780 You can see we finish the smaller downloads relatively quickly. We're really limited by the slowest download here, I'm not sure there's much we...

I experimented a little bit with this in the `pool` branch, along with a `try_steal` method that enables reusing pointers that have not been deallocated. Unfortunately, I'm not seeing much...

Rethinking this, it is still a useful configuration method as currently, dropping a guard can lead to unexpected latency spikes, even with the default batch size. Unfortunately exposing this conditionally...

Yes, I completely agree. I was actually meaning to change this a while ago but it fell off my radar. I think we should probably just remove the `Clone` implementation,...