Iñaki Baz Castillo
Iñaki Baz Castillo
IMHO this is not so easy. AFAIK the `httpServer` will emit `upgrade` upon receipt of a GET request with header "Upgrade", and it is in that event where existing WS...
Well, `Router#all()` already respond to unknown verbs, am I wrong?: ``` // create Router#VERB functions methods.concat('all').forEach(function(method){ Router.prototype[method] = function (path) { var route = this.route(path) route[method].apply(route, slice.call(arguments, 1)) return this...
Since `app.xxxx()` is supposed to be a simple proxy to the main `Router#xxxx()`, shouldn't the behavior be the same?
> I don't think there's a guarantee that I will get a 'connect' for a webSockServer object always, after a 'request' that does an accept? Yes, there is. > before...
Makes sense. Can you create a PR?
I don't think that makes many sense. I understand that you already have WebSocket code based on `WebSocketClient` API in your Node.js, but the browser exposes a standard W3C API...
Have you tested this PR?
ok, please confirm when tested.
**Why** are you passing an array of strings instead of a single string? Where did you read that in the docs?
@fresheneesz note that the W3C WebSocket API (for browsers) does not implement this feature. I mean: in the browser you cannot get (via JS I mean) the HTTP error code...