WebSocket-Node icon indicating copy to clipboard operation
WebSocket-Node copied to clipboard

add temp socket error handler in case error occur before accept #407

Open panshengjie opened this issue 4 years ago • 4 comments

panshengjie avatar Jan 06 '21 03:01 panshengjie

Have you tested this PR?

ibc avatar Jan 06 '21 11:01 ibc

not test yet

---Original--- From: "Iñaki Baz Castillo"<[email protected]> Date: Wed, Jan 6, 2021 19:28 PM To: "theturtle32/WebSocket-Node"<[email protected]>; Cc: "Pan Shengjie"<[email protected]>;"Author"<[email protected]>; Subject: Re: [theturtle32/WebSocket-Node] add temp socket error handler in case error occur before accept #407 (#408)

Have you tested this PR?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

panshengjie avatar Jan 06 '21 12:01 panshengjie

ok, please confirm when tested.

ibc avatar Jan 06 '21 14:01 ibc

Hi, was curious if there was a reason this hasn't been merged into the main branch yet. I too have been running into the ECONNRESET error, and the changes here do appear to fix the issue.

ASBaj avatar Sep 08 '21 19:09 ASBaj

tested, and no harm, should merged

panshengjie avatar May 05 '23 11:05 panshengjie

actually it's ok far early , but I forgot this

panshengjie avatar May 05 '23 11:05 panshengjie